Skip to content

ref(tsc): code-mappings endpoint to apiOptions#112915

Merged
TkDodo merged 1 commit intomasterfrom
tkdodo/ref/code-mappings-endpoint-to-apiOptions
Apr 15, 2026
Merged

ref(tsc): code-mappings endpoint to apiOptions#112915
TkDodo merged 1 commit intomasterfrom
tkdodo/ref/code-mappings-endpoint-to-apiOptions

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Apr 14, 2026

No description provided.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 14, 2026
@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Apr 14, 2026

Sentry Snapshot Testing

Name Added Removed Modified Renamed Unchanged Status
sentry-frontend
sentry-frontend
0 0 0 0 204 ✅ Unchanged

@TkDodo TkDodo marked this pull request as ready for review April 14, 2026 15:19
@TkDodo TkDodo requested review from a team as code owners April 14, 2026 15:19
Comment on lines +123 to +125
queryKey: codeMappingsApiOptions({
orgSlug: organization.slug,
}).queryKey,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it's passed in should we alternately do this?

Suggested change
queryKey: codeMappingsApiOptions({
orgSlug: organization.slug,
}).queryKey,
queryKey,

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it’s a different key! The one we pass in is the one we need to update data - it contains orgSlug and query: {integrationId, cursor}.

for invalidation, we want to match all code-mappings, so it’s just the slug with an empty query.

@TkDodo TkDodo merged commit 71191ad into master Apr 15, 2026
66 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/code-mappings-endpoint-to-apiOptions branch April 15, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants